jonnybot0 commented on code in PR #277:
URL: https://github.com/apache/groovy-geb/pull/277#discussion_r2164672603
##########
doc/manual/src/docs/asciidoc/080-javascript.adoc:
##########
@@ -291,24 +293,24 @@
include::{cm-snippets-dir}/geb/js/AlertAndConfirmSupport.groovy[tag=alert,indent
The first method, `withAlert()`, is used to verify actions that will produce
an alert dialog.
This method returns the alert message.
-Given the following HTML…
+Given the following HTML...
[source,html]
----
include::{snippets-dir}/javascript/AlertSpec.groovy[tag=alert_html,indent=0]
----
-The `withAlert()` method is used like so…
+The `withAlert()` method is used like so...
[source,groovy]
----
include::{snippets-dir}/javascript/AlertSpec.groovy[tag=alert,indent=0]
----
-If an alert dialog is not raised by the given “actions” closure, an
`AssertionError` will be thrown.
+If an alert dialog is not raised by the given "`actions`" closure, an
`AssertionError` will be thrown.
Review Comment:
Almost feel like we could do without the quotes entirely and just backticks
for code. Indeed, looking at a local build, it looks like asciidoctor just
skips over the backticks where present?
This is the only thing I would change: replace "\` with just plain \`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
