On Monday 01 October 2007 22:15:20 Peter Clifton wrote: > Hi, > > Is the following commit of any interest for inclusion in mainline? > > I've written it to allow multiple .deb packages to install global symbol > sources without requiring them to edit the same config files (either > geda-clib.scm or system-gafrc). > > It is part of my patch series for CUED, as we've got some site specific > global symbols to install and I wanted to keep them in a separate > package to the stock geda-symbols. (Ok, for full disclosure, our "stock" > geda-symbols has patches to remove some stuff we don't need). > > I've not done this, however the code could also load fonts this way.. > and any other .scm files we want to load from system-gafrc. If there is > any desire to do this, we could rename the dir from clib.d to gafrc.d > perhaps??
Would the following:
;; Returns #t or #f depending on whether the given path is a regular file
not be clearer as:
;; Returns #t if the given path is a regular file, otherwise #f.
(etc for other instances).
Also, some other things
1. "is_regular" should be "regular-file?"
2. "ends_scm" could become "has-suffix?", which would be a generic function
for comparing string suffixes. I note that ends_scm is only called in
one place.
3. Could the directory just be "gafrc.d"? That might make it even more
useful as a place to dump config scripts. Then "geda-clibd-path" could
be renamed to "geda-confd-path".
4. How much of this code can be moved into libgeda/scheme/geda.scm?
Very very good idea, however!
Peter
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
