> Another (hopefully last) set of nitpicks: > > > You should probably load the default font *before* reading the configuration > directory, because something in the configuration directory might want to > redefine the font!
Done, although thinking about it - unless there is reason not to, we should process the gafrc.d dir last of all, in case someone wants to override anything further down in the system-gafrc file. > "otherwise or #f" --> "otherwise #f" (comment for has-suffix?) Fixed > In load-scheme-dir you don't check if scheme-dir is a directory, merely > whether it exists. What does (opendir scheme-dir) do if scheme-dir is, say, > a device? I've added a directory check, and an (access? path R_OK) check to ensure its readable. It still gives: "Probably parenthesis mismatch in /home/pcjc2/geda/share/gEDA/system-gafrc" if gafrc.d is readable, but not executable - however I wasn't sure if adding X_OK was particularly portable. > Other than that, looks nice. :) I had to look up the semantics of "do" > loops > in Lisp-like languages to understand what was going on! Me too... the directory listing example came from: http://www.gnu.org/software/guile/manual/html_node/File-System.html#File-System I already sent Paul the packages last night. He may not have built them yet, but for the sake of not clogging his inbox, I've not sent updated versions. (There are bound to be other bugs to iron out, and I can update then). Peter _______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
