On Mon, 2007-10-01 at 23:01 +0100, Peter TB Brett wrote:
> Would the following:
>
> ;; Returns #t or #f depending on whether the given path is a regular file
>
> not be clearer as:
>
> ;; Returns #t if the given path is a regular file, otherwise #f.
>
>
> (etc for other instances).
Changed
> Also, some other things
>
> 1. "is_regular" should be "regular-file?"
Changed
> 2. "ends_scm" could become "has-suffix?", which would be a generic function
> for comparing string suffixes. I note that ends_scm is only called in
> one place.
Changed to (has-suffix? str suf)
> 3. Could the directory just be "gafrc.d"? That might make it even more
> useful as a place to dump config scripts. Then "geda-clibd-path" could
> be renamed to "geda-confd-path".
Would you suggest using this mechanism to load the gschem fonts too? I
only note that we'd loose the ability to specifically:
(display "Failed to load default font.\n")
if for some reason the fonts aren't loaded by any gafrc.d .scm file.
> 4. How much of this code can be moved into libgeda/scheme/geda.scm?
I've moved the regular-file? and has-suffix?
> Very very good idea, however!
Thanks,
I've still to decide if we should install under $GEDA_DATA_DIR/scheme
and symlink to those from $GEDA_DATA_DIR/gafrc.d/*
For now, the patch installs geda-clib.scm directly in
$GEDA_DATA_DIR/gafrc.d/
Peter
_______________________________________________
geda-dev mailing list
[email protected]
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
