On Tuesday 02 October 2007 00:17:49 Peter Clifton wrote: > On Mon, 2007-10-01 at 23:56 +0100, Peter TB Brett wrote: > > On Monday 01 October 2007 23:24:41 Peter Clifton wrote: > > > > 4. How much of this code can be moved into libgeda/scheme/geda.scm? > > > > > > I've moved the regular-file? and has-suffix? > > > > One final suggestion: a function "load-scheme-dir" (or "load-conf-dir") > > or similar, which can be used for a gschemrc.d (gnetlistrc.d, ...). This > > function could be defined in geda.scm. > > See: > > commit f2c4ecba5d383a37e7ab942188e50d6f72a9ca50 > Author: Peter Clifton <[EMAIL PROTECTED]> > Date: Tue Oct 2 00:16:09 2007 +0100 > > Alter system-gafrc to process .scm files in $GEDA_DATA_DIR/gafrc.d/ > > This change allows each symbol package (e.g. geda-symbols) to install a > scheme config file under this dir to load its contents. This allows > additional symbol packages to be installed globally without needing to > edit either geda-clib.scm or system-gafrc. > > Also moves the installation of geda-clib.scm into this directory.
Another (hopefully last) set of nitpicks:
You should probably load the default font *before* reading the configuration
directory, because something in the configuration directory might want to
redefine the font!
"otherwise or #f" --> "otherwise #f" (comment for has-suffix?)
In load-scheme-dir you don't check if scheme-dir is a directory, merely
whether it exists. What does (opendir scheme-dir) do if scheme-dir is, say,
a device?
Other than that, looks nice. :) I had to look up the semantics of "do" loops
in Lisp-like languages to understand what was going on!
Cheers,
Peter
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
