On Tuesday 07 October 2008 18:58:30 Werner Hoch wrote: > On Dienstag, 7. Oktober 2008, Peter Clifton wrote: > > On Tue, 2008-10-07 at 09:02 +0200, Werner Hoch wrote: > > > I'd use the same space separated list of attributes as the > > > always-promote-attributes variable in libgeda. > > > > Why does the attribute viewer need to use that list directly? > > I've tried to say that I'd use the same format, not the same list. > Sorry for the confusion. > > > There are already various helper functions to "get promotable > > attributes", even if the preview widget doesn't normally promote > > them. Unless I've misunderstood something, we don't need to duplicate > > any functionality to check for promotable attributes. > > > > See the recently added function: > > > > GList *o_complex_get_promotable (TOPLEVEL *toplevel, OBJECT *object, > > int detach); > > I've looked into it. But I think I cannot use it. If a symbol is opened > directly the attributes are just plain text objects. Not elements of a > component. > > He're the current hack of the component selector: > http://repo.or.cz/w/geda-gaf/werner.git?a=commitdiff;h=2b0ae504fa605f4e36a4 >54109883222344b39bb1 >
Hrm. My way, ugly though it might be, would be to utilise in some way the fact
that the preview pane fully loads the symbol. I assume you are, right?
The o_complex_get_promotable() function could probably be made a wrapper
around a function that filters an object list for promotable attributes. That
would be of greater general utility *and* more elegant at the same time,
IMHO.
Peter
--
Peter Brett
Electronic Systems Engineer
Integral Informatics Ltd
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
