On Wed, 2008-10-08 at 21:23 +0200, Werner Hoch wrote: > Hi Peter, > We need a function that collects all attributes and a second that > filters the first list to fit the current requirements. > > In the current two functions o_complex_get_promotable and > o_complex_is_eligible_attribute things are mixed together a little bit.
They are a little confused, I'll grant that. I added o_complex_get_promotable() before I reworked the o_.._add() into o_..._new(), such that all the functions could return a single OBJECT *. That meant promotion had to happen outside o_complex_new(), and I think the code is clearer for the distinction. I'll grant that o_complex_is_eligible_attribute() is horrid in a number of ways. Shall I knock up a patch to finish that clean-up? > > Indentation bug / typo. > > you're pedantic today ;-), fixed > I remember that I've used this style while studiing. Sorry. I'll put it down to stress that I'm complaining - no harm meant by it. I spent a lot of time trying to cut out mixed tab/space etc. in any code that I touch, its a pet hate. I don't like writing patches _just_ to do that though. > BTW: Have you installed any pre commit hooks in git to detect such > things? No, although git does winge about trailing whitespace automatically. > > Are you using stgit? It would be about perfect for rolling any > > desired changes into these patches. > > I've installed it but I'm still using git [reset rebase cherry-pick]. If you're going to use it, grab the latest version from git. http://procode.org/stgit/ http://homepage.ntlworld.com/cmarinas/stgit.git It is kinder to your repository (doesn't eat your work like some older versions could do). stg is really really handy for patch management. For example, branch off your current work, then decide how many patches you want to be in the stgit series. stg init stg uncommit -n {number} stg series (shows the patch series) stg push / pop (apply / de-apply the patches) stg edit (commit messages) stg refresh (update the current patch) stg commit (commit one or more patchs as a "proper" git commit) stg rebase {new_base} (rebase current patch series) I used to use git + cherry-pick + rebase, but now I wouldn't look back. -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) _______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
