On Mittwoch, 8. Oktober 2008, Peter Clifton wrote: > On Wed, 2008-10-08 at 21:23 +0200, Werner Hoch wrote: > > In the current two functions o_complex_get_promotable and > > o_complex_is_eligible_attribute things are mixed together a little > > bit. > > Like this: > > http://repo.or.cz/w/geda-gaf/pcjc2.git?a=commitdiff;h=333917a672084c2 >3e77b7a2f62616e6c516f2df8 > > It isn't much simpler, and in fact introduces a second iteration over > the list. (One iteration over all OBJECTs to build the list, then > iterate over that list to filter it).
It isn't yet much simpler, but now you can cut down the o_complex_is_eligible_attribute function and integrate it into the o_complex_get_promotable function. Thus the o_complex_get_promotable acts as a filter around o_complex_get_toplevel_attribs. Regards Werner _______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
