Hi
> Some notes:
> - I'd rather not add new features to the search dialog, until we solve the 
> code duplication with the filelist, the collection window etc.
>
> - I did some smaller changes to bar_gps.c. You should merge them with your 
> code.
>   
It seems there are several changes to libchamplain. There are now 
compiler warnings about deprecated functions and typecasting. There are 
also a couple of programming errors in bar_gps.c that I should correct, 
so I will make a patch to correct all this.

I see your change takes into account both libchamplain-0.3 and 
libchamplain-0.3.3, but I don't find 0.3  available anywhere. The main 
project page has 0.3.3 as a package, the debian unstable repository has 
0.3.3, and the project git repository only has a tag for 0.3.3, not for 0.3.

Is it worth putting ifdefs into the code to take into account old 
versions that are not readily available? Should I make the patch cater 
for both 0.3 and 0.3.3 versions, or just for the 0.3.3?


Colin Clark...

------------------------------------------------------------------------------
_______________________________________________
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Reply via email to