----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/759/#review1371 -----------------------------------------------------------
It's naive because it just copies everything over one at a time without any side effects. The side effects might be functionally necessary, but when they're turned on you might run into problems where things have to be done in a certain order for the system to stay in a meaningful state. Making it transition through illegal states may not work, depending on how things are implemented. src/arch/x86/utility.cc <http://reviews.m5sim.org/r/759/#comment1824> You don't want this, you want arch/x86/registers.hh. src/arch/x86/utility.cc <http://reviews.m5sim.org/r/759/#comment1821> Delete this code, don't comment it out. src/arch/x86/utility.cc <http://reviews.m5sim.org/r/759/#comment1822> NUM_INTREGS won't get them all. You want NumIntRegs as defined in registers.hh. The names are a bit confusing. src/arch/x86/utility.cc <http://reviews.m5sim.org/r/759/#comment1823> Same as above, NumFloatRegs. - Gabe On 2011-06-27 16:59:27, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/759/ > ----------------------------------------------------------- > > (Updated 2011-06-27 16:59:27) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > x86: Implements copyRegs() function > The copyRegs() function for x86 is currently unimplemented. This patch > provides an implementation. > > Apart from this patch, I have another question. In the function > copyMiscRegs(), a comment appears that 'it has been implemented naively.' > Why the comment? What would an accurate implementation look like? > > > Diffs > ----- > > src/arch/x86/utility.cc 0412ba528ad6 > > Diff: http://reviews.m5sim.org/r/759/diff > > > Testing > ------- > > > Thanks, > > Nilay > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
