> On 2011-07-07 19:26:15, Nilay Vaish wrote: > > src/arch/x86/utility.cc, line 219 > > <http://reviews.m5sim.org/r/759/diff/3/?file=13302#file13302line219> > > > > I can change the comment to -- > > > > // This function assumes that the registers are consistent amongst > > themselves. Hence, side effects affecting the registers themselves need not > > be taken care of. But any other side effects, like TLB invalidation, would > > need to be. > >
How about // This function assumes no side effects other than TLB invalidation need to be considered while copying state. That will likely not be true in the future. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/759/#review1395 ----------------------------------------------------------- On 2011-07-07 07:59:18, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/759/ > ----------------------------------------------------------- > > (Updated 2011-07-07 07:59:18) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > x86: Implements copyRegs() function > The copyRegs() function for x86 is currently unimplemented. This patch > provides an implementation. > > > Diffs > ----- > > src/arch/x86/utility.cc fad37c6670a6 > > Diff: http://reviews.m5sim.org/r/759/diff > > > Testing > ------- > > > Thanks, > > Nilay > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
