----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/904/#review1637 -----------------------------------------------------------
src/cpu/BaseCPU.py <http://reviews.m5sim.org/r/904/#comment2117> This is wrong. Boiled down, it's saying: if x86 or arm: foo; elif x86 or arm: bar; bar will never happen. It's not quite that simple, but that doesn't change the nature of the problem. Have you run regressions on this? I expect it will cause problems in at least one of x86 or ARM. - Gabe On 2011-11-03 13:30:18, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/904/ > ----------------------------------------------------------- > > (Updated 2011-11-03 13:30:18) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ARM: Add support for having a TLB cache. > > > Diffs > ----- > > src/cpu/BaseCPU.py 5fb918115c07 > > Diff: http://reviews.m5sim.org/r/904/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
