-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/954/#review1791
-----------------------------------------------------------


See comment below. Also, please put information in your commit message about 
when something breaks and how this fixes it. 


configs/common/Simulation.py
<http://reviews.m5sim.org/r/954/#comment2324>

    Does normal switching fo CPUs work with this code removed?  I guess you 
removed to for ruby running with a timing cpu? 


- Ali


On 2011-12-25 08:53:30, Nilay Vaish wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/954/
> -----------------------------------------------------------
> 
> (Updated 2011-12-25 08:53:30)
> 
> 
> Review request for Default.
> 
> 
> Summary
> -------
> 
> Simulation.py: Bug in setting switch_cpus
> switch_cpus is being set whenever the CPU class is specified. This
> results in error when restoring from a checkpoint as switch_cpus
> are not connected to anything.
> 
> 
> Diffs
> -----
> 
>   configs/common/Simulation.py ca98021c3f96 
>   src/dev/io_device.cc ca98021c3f96 
> 
> Diff: http://reviews.m5sim.org/r/954/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nilay
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to