> On 2012-01-01 16:40:59, Ali Saidi wrote: > > See comment below. Also, please put information in your commit message > > about when something breaks and how this fixes it.
If that line of code is present, then on restoring from a checkpoint with a timing cpu (and not atomic cpu) enabled, the following error is received -- panic: Pio port not connected to anything! @ cycle 0 [init:build/X86_FS/dev/io_device.cc, line 74] Memory Usage: 3370604 KBytes Program aborted at cycle 0 It is the pio port of switch_cpus.interrupts which is not attached to anything. Hence, we need to remove this particular line. To me it seems that switch_cpus variable is required only when the option for switching cpus has been specified. This is means that the line should appear where this option is being checked, where it already does appear. In fact, I don't even see the point in creating switch_cpus variable with out checking this particular option. > On 2012-01-01 16:40:59, Ali Saidi wrote: > > configs/common/Simulation.py, line 122 > > <http://reviews.m5sim.org/r/954/diff/1/?file=16777#file16777line122> > > > > Does normal switching fo CPUs work with this code removed? I guess you > > removed to for ruby running with a timing cpu? As I said above, this line again appears under the option for switched cpus. Therefore, I expect switching of CPUs to work as before. Secondly, this change has nothing to do with Ruby. It is about restoring from a checkpoint with a timing cpu. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/954/#review1791 ----------------------------------------------------------- On 2011-12-25 08:53:30, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/954/ > ----------------------------------------------------------- > > (Updated 2011-12-25 08:53:30) > > > Review request for Default. > > > Summary > ------- > > Simulation.py: Bug in setting switch_cpus > switch_cpus is being set whenever the CPU class is specified. This > results in error when restoring from a checkpoint as switch_cpus > are not connected to anything. > > > Diffs > ----- > > configs/common/Simulation.py ca98021c3f96 > src/dev/io_device.cc ca98021c3f96 > > Diff: http://reviews.m5sim.org/r/954/diff > > > Testing > ------- > > > Thanks, > > Nilay > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
