----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/982/#review1876 -----------------------------------------------------------
Thanks for taking the time to do this Tony! It's pretty much looks great, however, the style guide says that member variables should be mixed case and not contain underscores (e.g. instructionsExecuted instead of instructions_executed). However, we do tends to name the stats output at instructions_executed which is a bit annoying. Unless someone feels strongly I think it would be best to stick to the style guide. - Ali On 2012-01-09 13:54:23, Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/982/ > ----------------------------------------------------------- > > (Updated 2012-01-09 13:54:23) > > > Review request for Default. > > > Summary > ------- > > Stats: Add stats for instructions and micro ops, both globally and per CPU. > > Adds an instructions_executed and operations_executed stat for each CPU > model. Also creates a new global stat sim_uOps which counts all operations. > Changes sim_insts to count instructions. > > > Diffs > ----- > > src/arch/noisa/cpu_dummy.hh UNKNOWN > src/cpu/base.hh UNKNOWN > src/cpu/base.cc UNKNOWN > src/cpu/inorder/cpu.hh UNKNOWN > src/cpu/inorder/cpu.cc UNKNOWN > src/cpu/inorder/inorder_dyn_inst.hh UNKNOWN > src/cpu/o3/commit.hh UNKNOWN > src/cpu/o3/commit_impl.hh UNKNOWN > src/cpu/o3/cpu.hh UNKNOWN > src/cpu/o3/cpu.cc UNKNOWN > src/cpu/simple/base.hh UNKNOWN > src/cpu/simple/base.cc UNKNOWN > src/cpu/thread_state.hh UNKNOWN > src/cpu/thread_state.cc UNKNOWN > src/sim/stat_control.cc UNKNOWN > > Diff: http://reviews.m5sim.org/r/982/diff > > > Testing > ------- > > > Thanks, > > Anthony > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
