> On 2012-01-11 10:42:36, Korey Sewell wrote: > > src/cpu/inorder/cpu.cc, line 646 > > <http://reviews.m5sim.org/r/982/diff/2/?file=20361#file20361line646> > > > > Is "Operations" the right word here? It seems ambiguous. > > > > Assuming that numSimulatedInstructions means macro-ops, I think the > > next derivative of that should mean "numSimulatedMicroOps". > > > > Although the comment clarifies this, operations sounds more like the > > number of Functional Unit *operations* then micro-ops in my opinion.
I like operations, but I think it's open to debate. macro-ops and micro-ops are a bit weird. Is an instruction that isn't (cracked, micro-coded, whatever) a macro-op or a micro-op? I think instructions should be whatever is derived from a "word" of machine code be it 1 or N instruction and then there needs to be something that is everything that has execute() called on it. This isn't really micro-ops, because you could have a signal instruction that isn't a micro-op, but it should count toward the total. ops or operations makes sense to me here. - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/982/#review1906 ----------------------------------------------------------- On 2012-01-10 08:47:41, Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/982/ > ----------------------------------------------------------- > > (Updated 2012-01-10 08:47:41) > > > Review request for Default. > > > Summary > ------- > > Changeset 8650:2b39160c9a96 > --------------------------- > [mq]: bug.patch > > > Diffs > ----- > > src/arch/noisa/cpu_dummy.hh UNKNOWN > src/cpu/base.hh UNKNOWN > src/cpu/base.cc UNKNOWN > src/cpu/inorder/cpu.hh UNKNOWN > src/cpu/inorder/cpu.cc UNKNOWN > src/cpu/inorder/inorder_dyn_inst.hh UNKNOWN > src/cpu/o3/commit.hh UNKNOWN > src/cpu/o3/commit_impl.hh UNKNOWN > src/cpu/o3/cpu.hh UNKNOWN > src/cpu/o3/cpu.cc UNKNOWN > src/cpu/simple/base.hh UNKNOWN > src/cpu/simple/base.cc UNKNOWN > src/cpu/thread_state.hh UNKNOWN > src/cpu/thread_state.cc UNKNOWN > src/sim/stat_control.cc UNKNOWN > > Diff: http://reviews.m5sim.org/r/982/diff > > > Testing > ------- > > > Thanks, > > Anthony > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
