----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/986/#review1956 -----------------------------------------------------------
Overall, this looks a lot better. The only thing I really want an answer on is why you got rid fo the "using namespace std" in those .cc files. Other than that, this is basically ready. SConstruct <http://reviews.m5sim.org/r/986/#comment2462> I'm happy to have you fix the struct/class stuff and get rid of -Wno-mismatched-tags src/arch/arm/isa/templates/basic.isa <http://reviews.m5sim.org/r/986/#comment2459> Don't need the comment here. src/dev/ide_ctrl.cc <http://reviews.m5sim.org/r/986/#comment2460> This should be ok (it's in a .cc file). What's wrong? src/dev/ns_gige.cc <http://reviews.m5sim.org/r/986/#comment2461> Same here - Nathan On 2012-01-12 23:36:49, Koan-Sin Tan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/986/ > ----------------------------------------------------------- > > (Updated 2012-01-12 23:36:49) > > > Review request for Default. > > > Summary > ------- > > Initial patch to make gem5 compile with clang/llvm. Tested on Mac OS X 10.7.2 > + clang/llvm from Xcode 4.2 > > > Diffs > ----- > > SConstruct UNKNOWN > src/SConscript UNKNOWN > src/arch/alpha/tlb.cc UNKNOWN > src/arch/arm/insts/static_inst.hh UNKNOWN > src/arch/arm/insts/vfp.hh UNKNOWN > src/arch/arm/isa/templates/basic.isa UNKNOWN > src/arch/generic/memhelpers.hh UNKNOWN > src/arch/mips/faults.hh UNKNOWN > src/arch/mips/faults.cc UNKNOWN > src/arch/x86/bios/intelmp.cc UNKNOWN > src/base/fast_alloc.cc UNKNOWN > src/base/range_map.hh UNKNOWN > src/base/stl_helpers.hh UNKNOWN > src/cpu/o3/decode_impl.hh UNKNOWN > src/cpu/o3/iew.hh UNKNOWN > src/cpu/o3/inst_queue.hh UNKNOWN > src/cpu/o3/inst_queue_impl.hh UNKNOWN > src/cpu/o3/mem_dep_unit.cc UNKNOWN > src/cpu/o3/sat_counter.hh UNKNOWN > src/dev/alpha/tsunami_cchip.cc UNKNOWN > src/dev/alpha/tsunami_io.cc UNKNOWN > src/dev/arm/pl111.hh UNKNOWN > src/dev/arm/pl111.cc UNKNOWN > src/dev/copy_engine.cc UNKNOWN > src/dev/ide_ctrl.cc UNKNOWN > src/dev/ns_gige.cc UNKNOWN > src/dev/pciconfigall.cc UNKNOWN > src/dev/pcidev.cc UNKNOWN > src/mem/cache/base.hh UNKNOWN > src/sim/process_impl.hh UNKNOWN > src/sim/syscall_emul.hh UNKNOWN > > Diff: http://reviews.m5sim.org/r/986/diff > > > Testing > ------- > > > Thanks, > > Koan-Sin > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
