> On 2012-01-17 11:00:05, Nathan Binkert wrote: > > src/dev/ide_ctrl.cc, line 45 > > <http://reviews.m5sim.org/r/986/diff/3/?file=20975#file20975line45> > > > > This should be ok (it's in a .cc file). What's wrong? > > Ali Saidi wrote: > It's the std::set vs Packet::set issue. > > It looks like a clang bug... http://llvm.org/bugs/show_bug.cgi?id=7247 > > Ali > > > Gabe Black wrote: > What about adding "using std::set;"? Or is it "using namespace std::set"? > One of those might lead clang to the right answer without adding std:: all > over. > > Andreas Hansson wrote: > Indeed, instead of the "using namespace std", we could add the > appropriate "using std::list", "using std::vector" etc. From the clang bug > description it looks like it should be resolved? >
I think that we're approaching the realm of having talked about this patch way too much, but I like the idea of the using namespace std::list, etc. instead of sprinkling std:: all over. Mainly because the latter might get undone and break clang, but with the former, we can put in a comment. Either way, I think that we should have a comment like this up where the using namespace should be. // Clang doesn't deal with the existence of std::set and Packet::set properly, so we // can't do this: // using namespace std; - Nathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/986/#review1956 ----------------------------------------------------------- On 2012-01-12 23:36:49, Koan-Sin Tan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/986/ > ----------------------------------------------------------- > > (Updated 2012-01-12 23:36:49) > > > Review request for Default. > > > Summary > ------- > > Initial patch to make gem5 compile with clang/llvm. Tested on Mac OS X 10.7.2 > + clang/llvm from Xcode 4.2 > > > Diffs > ----- > > SConstruct UNKNOWN > src/SConscript UNKNOWN > src/arch/alpha/tlb.cc UNKNOWN > src/arch/arm/insts/static_inst.hh UNKNOWN > src/arch/arm/insts/vfp.hh UNKNOWN > src/arch/arm/isa/templates/basic.isa UNKNOWN > src/arch/generic/memhelpers.hh UNKNOWN > src/arch/mips/faults.hh UNKNOWN > src/arch/mips/faults.cc UNKNOWN > src/arch/x86/bios/intelmp.cc UNKNOWN > src/base/fast_alloc.cc UNKNOWN > src/base/range_map.hh UNKNOWN > src/base/stl_helpers.hh UNKNOWN > src/cpu/o3/decode_impl.hh UNKNOWN > src/cpu/o3/iew.hh UNKNOWN > src/cpu/o3/inst_queue.hh UNKNOWN > src/cpu/o3/inst_queue_impl.hh UNKNOWN > src/cpu/o3/mem_dep_unit.cc UNKNOWN > src/cpu/o3/sat_counter.hh UNKNOWN > src/dev/alpha/tsunami_cchip.cc UNKNOWN > src/dev/alpha/tsunami_io.cc UNKNOWN > src/dev/arm/pl111.hh UNKNOWN > src/dev/arm/pl111.cc UNKNOWN > src/dev/copy_engine.cc UNKNOWN > src/dev/ide_ctrl.cc UNKNOWN > src/dev/ns_gige.cc UNKNOWN > src/dev/pciconfigall.cc UNKNOWN > src/dev/pcidev.cc UNKNOWN > src/mem/cache/base.hh UNKNOWN > src/sim/process_impl.hh UNKNOWN > src/sim/syscall_emul.hh UNKNOWN > > Diff: http://reviews.m5sim.org/r/986/diff > > > Testing > ------- > > > Thanks, > > Koan-Sin > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
