> On 2012-01-12 06:05:33, Andreas Hansson wrote: > > src/arch/x86/bios/intelmp.cc, line 82 > > <http://reviews.m5sim.org/r/986/diff/2/?file=20759#file20759line82> > > > > Should we do this based on if(sizeof(T) > 1), else guestVal = 0? > >
sounds good > On 2012-01-12 06:05:33, Andreas Hansson wrote: > > src/arch/x86/isa_traits.hh, line 90 > > <http://reviews.m5sim.org/r/986/diff/2/?file=20760#file20760line90> > > > > Opening namespaces in headers is never a good idea. This essentially > > means every place we include it this namespace is now opened. Is this > > really what we want? There are some gtoh() in .hh files. I don't know how to get them compiled without making either big changes or ugly 'using namepace ...' before some "#include xxx.hh" yet > On 2012-01-12 06:05:33, Andreas Hansson wrote: > > src/dev/copy_engine.cc, line 48 > > <http://reviews.m5sim.org/r/986/diff/2/?file=20774#file20774line48> > > > > Why does the std cause a problem with the packet->set? Packet does not > > inherit from any STL container class. I don't get why there is any > > potential overloading. this kind of ambiguity has nothing to do with inheritance as far as I can tell - Koan-Sin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/986/#review1929 ----------------------------------------------------------- On 2012-01-12 04:38:10, Koan-Sin Tan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/986/ > ----------------------------------------------------------- > > (Updated 2012-01-12 04:38:10) > > > Review request for Default. > > > Summary > ------- > > Initial patch to make gem5 compile with clang/llvm. Tested on Mac OS X 10.7.2 > + clang/llvm from Xcode 4.2 > > > Diffs > ----- > > SConstruct UNKNOWN > src/SConscript UNKNOWN > src/arch/alpha/isa_traits.hh UNKNOWN > src/arch/alpha/tlb.cc UNKNOWN > src/arch/arm/insts/static_inst.hh UNKNOWN > src/arch/arm/insts/vfp.hh UNKNOWN > src/arch/arm/isa/templates/basic.isa UNKNOWN > src/arch/x86/bios/intelmp.cc UNKNOWN > src/arch/x86/isa_traits.hh UNKNOWN > src/base/fast_alloc.cc UNKNOWN > src/base/range_map.hh UNKNOWN > src/base/stl_helpers.hh UNKNOWN > src/cpu/o3/decode_impl.hh UNKNOWN > src/cpu/o3/iew.hh UNKNOWN > src/cpu/o3/inst_queue.hh UNKNOWN > src/cpu/o3/inst_queue_impl.hh UNKNOWN > src/cpu/o3/mem_dep_unit.cc UNKNOWN > src/cpu/o3/sat_counter.hh UNKNOWN > src/dev/alpha/tsunami_cchip.cc UNKNOWN > src/dev/alpha/tsunami_io.cc UNKNOWN > src/dev/arm/pl111.hh UNKNOWN > src/dev/arm/pl111.cc UNKNOWN > src/dev/copy_engine.cc UNKNOWN > src/dev/ide_ctrl.cc UNKNOWN > src/dev/ns_gige.cc UNKNOWN > src/dev/pciconfigall.cc UNKNOWN > src/dev/pcidev.cc UNKNOWN > src/mem/cache/base.hh UNKNOWN > > Diff: http://reviews.m5sim.org/r/986/diff > > > Testing > ------- > > > Thanks, > > Koan-Sin > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
