> On Feb. 2, 2012, 8:04 a.m., Steve Reinhardt wrote: > > src/cpu/o3/commit_impl.hh, line 529 > > <http://reviews.gem5.org/r/1007/diff/2/?file=21612#file21612line529> > > > > It looks like we already have the DynInstPtr here in the case where the > > rob is not empty... in fact just looking at this code I'd say that the call > > to getSquashInst() below will only ever return either NULL or whatever > > rob->readHeadInst() returns here. Right?
Reading the code, it seems like it will always return NULL. I think neither of those two sequence numbers can be possibly in the ROB. I'll put an assert statement and test if anything other NULL is returned. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1007/#review2052 ----------------------------------------------------------- On Jan. 28, 2012, 9 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1007/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2012, 9 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8731:10a06bd36839 > --------------------------- > O3 CPU: Provide the squashing instruction > This patch adds a function to the ROB that will get the squashing instruction > from the ROB's list of instructions. This squashing instruction is used for > figuring out the macroop from which the fetch stage should fetch the microops. > Further, a check has been added that if the instructions are to be fetched > from the cache maintained by the fetch stage, then the data in the cache > should > be valid and the PC of the thread being fetched from is same as the address of > the cache block. > > > Diffs > ----- > > src/cpu/o3/commit_impl.hh 9d7c1dc54954 > src/cpu/o3/fetch_impl.hh 9d7c1dc54954 > src/cpu/o3/rob.hh 9d7c1dc54954 > src/cpu/o3/rob_impl.hh 9d7c1dc54954 > > Diff: http://reviews.gem5.org/r/1007/diff/diff > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
