> On Feb. 2, 2012, 1:04 a.m., Gabe Black wrote: > > src/cpu/o3/rob_impl.hh, line 550 > > <http://reviews.gem5.org/r/1007/diff/2/?file=21615#file21615line550> > > > > This whole function could be replaced by (or perhaps wrap) one of the > > STL searching functions. If there isn't one that's a member of whatever > > type the instruction list is, then I'm pretty sure there's one in the > > generic algorithms stuff. > > > > Unfortunately I couldn't tell you off hand what it's called or where to > > find it, but I'm confident it's in there because I think I've used it > > before. It might even use some fancy schmancy algorithm that would be > > faster than this for loop, but if it's a linked list likely not. > > Nilay Vaish wrote: > I think you are talking about the search function. It requires a > comparison > operator for dynamic instructions. I am not sure if this is necessarily > less > amount of code. > > Gabe Black wrote: > This looks like what I was thinking of: > > http://www.sgi.com/tech/stl/find.html
I don't think this would work. Here is the prototype of the function -- InputIterator find(InputIterator first, InputIterator last, Type const &value); The function returns the first iterator i in the range [first, last) such that *i == value. In our case, the equality is not being tested on the underlying object, but on one of its member. The find_if function solves this problem, but again does not seem like less amount of code. http://www.sgi.com/tech/stl/find_if.html - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1007/#review2048 ----------------------------------------------------------- On Jan. 28, 2012, 9 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1007/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2012, 9 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8731:10a06bd36839 > --------------------------- > O3 CPU: Provide the squashing instruction > This patch adds a function to the ROB that will get the squashing instruction > from the ROB's list of instructions. This squashing instruction is used for > figuring out the macroop from which the fetch stage should fetch the microops. > Further, a check has been added that if the instructions are to be fetched > from the cache maintained by the fetch stage, then the data in the cache > should > be valid and the PC of the thread being fetched from is same as the address of > the cache block. > > > Diffs > ----- > > src/cpu/o3/commit_impl.hh 9d7c1dc54954 > src/cpu/o3/fetch_impl.hh 9d7c1dc54954 > src/cpu/o3/rob.hh 9d7c1dc54954 > src/cpu/o3/rob_impl.hh 9d7c1dc54954 > > Diff: http://reviews.gem5.org/r/1007/diff/diff > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
