----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1011/#review2090 -----------------------------------------------------------
src/mem/cache/prefetch/Prefetcher.py <http://reviews.gem5.org/r/1011/#comment2579> Can we take this opportunity to remove the 'prefetch(er)_' prefixes from these param names? The original purpose was to distinguish them among the cache params, but that's not necessary anymore, and now it's just redundant and verbose. src/mem/cache/prefetch/base.hh <http://reviews.gem5.org/r/1011/#comment2578> How about some comments here? src/mem/cache/prefetch/ghb.hh <http://reviews.gem5.org/r/1011/#comment2580> Shouldn't these be removed since they're in the base class now? src/mem/cache/prefetch/tagged.hh <http://reviews.gem5.org/r/1011/#comment2581> Same here. src/mem/cache/prefetch/tagged.cc <http://reviews.gem5.org/r/1011/#comment2582> These initializations should be in the base constructor too. - Steve Reinhardt On Jan. 26, 2012, 4:30 a.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1011/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2012, 4:30 a.m.) > > > Review request for Default. > > > Description > ------- > > prefetcher: Make prefetcher a sim object instead of it being a parameter on > cache > > > Diffs > ----- > > src/mem/cache/BaseCache.py 78b08f92c290 > src/mem/cache/builder.cc 78b08f92c290 > src/mem/cache/cache.hh 78b08f92c290 > src/mem/cache/cache_impl.hh 78b08f92c290 > src/mem/cache/prefetch/Prefetcher.py PRE-CREATION > src/mem/cache/prefetch/SConscript 78b08f92c290 > src/mem/cache/prefetch/base.hh 78b08f92c290 > src/mem/cache/prefetch/base.cc 78b08f92c290 > src/mem/cache/prefetch/ghb.hh 78b08f92c290 > src/mem/cache/prefetch/ghb.cc 78b08f92c290 > src/mem/cache/prefetch/stride.hh 78b08f92c290 > src/mem/cache/prefetch/stride.cc 78b08f92c290 > src/mem/cache/prefetch/tagged.hh 78b08f92c290 > src/mem/cache/prefetch/tagged.cc 78b08f92c290 > > Diff: http://reviews.gem5.org/r/1011/diff/diff > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
