----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1011/#review1996 -----------------------------------------------------------
Any testing done? src/mem/cache/prefetch/base.hh <http://reviews.gem5.org/r/1011/#comment2495> Tick and unsigned int rather than int, or is there a reason to ever have negative values? src/mem/cache/prefetch/base.hh <http://reviews.gem5.org/r/1011/#comment2493> Is setCache necessary or can we do this in the constructor? src/mem/cache/prefetch/ghb.cc <http://reviews.gem5.org/r/1011/#comment2494> whitespace? src/mem/cache/prefetch/stride.cc <http://reviews.gem5.org/r/1011/#comment2496> whitespace? - Andreas Hansson On Jan. 26, 2012, 4:30 a.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1011/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2012, 4:30 a.m.) > > > Review request for Default. > > > Description > ------- > > prefetcher: Make prefetcher a sim object instead of it being a parameter on > cache > > > Diffs > ----- > > src/mem/cache/BaseCache.py 78b08f92c290 > src/mem/cache/builder.cc 78b08f92c290 > src/mem/cache/cache.hh 78b08f92c290 > src/mem/cache/cache_impl.hh 78b08f92c290 > src/mem/cache/prefetch/Prefetcher.py PRE-CREATION > src/mem/cache/prefetch/SConscript 78b08f92c290 > src/mem/cache/prefetch/base.hh 78b08f92c290 > src/mem/cache/prefetch/base.cc 78b08f92c290 > src/mem/cache/prefetch/ghb.hh 78b08f92c290 > src/mem/cache/prefetch/ghb.cc 78b08f92c290 > src/mem/cache/prefetch/stride.hh 78b08f92c290 > src/mem/cache/prefetch/stride.cc 78b08f92c290 > src/mem/cache/prefetch/tagged.hh 78b08f92c290 > src/mem/cache/prefetch/tagged.cc 78b08f92c290 > > Diff: http://reviews.gem5.org/r/1011/diff/diff > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
