----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1092/#review2309 -----------------------------------------------------------
Hi Andrew, This is great! How extensively have you managed to test this change? does it still work with standard switching? Does it work switching between timing and o3? I've made a few small comments for the patch that i'd like to see changed. Also, it would be really great if we could get this functionality into the normal config scripts. I would really like to see a regression test that uses this functionality because without it, it will probably get broken accidentally. Thanks again, Ali src/cpu/base.cc <http://reviews.gem5.org/r/1092/#comment2737> extraneous blank line src/cpu/o3/commit_impl.hh <http://reviews.gem5.org/r/1092/#comment2738> just remove old code please src/cpu/o3/cpu.cc <http://reviews.gem5.org/r/1092/#comment2739> what is the right way then? src/cpu/o3/lsq_unit.hh <http://reviews.gem5.org/r/1092/#comment2740> space between = please - Ali Saidi On March 11, 2012, 3:55 p.m., Andrew Lukefahr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1092/ > ----------------------------------------------------------- > > (Updated March 11, 2012, 3:55 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8896:fa56cab4f369 > --------------------------- > cpu : multiple switchout > > > Diffs > ----- > > src/cpu/o3/iew.hh ad5f1f128fafebd4c6641f72c7872d669c1dc239 > src/cpu/o3/lsq_unit.hh ad5f1f128fafebd4c6641f72c7872d669c1dc239 > src/cpu/o3/cpu.cc ad5f1f128fafebd4c6641f72c7872d669c1dc239 > src/cpu/o3/commit_impl.hh ad5f1f128fafebd4c6641f72c7872d669c1dc239 > src/cpu/base.cc ad5f1f128fafebd4c6641f72c7872d669c1dc239 > > Diff: http://reviews.gem5.org/r/1092/diff/ > > > Testing > ------- > > Allows multiple switchouts of O3CPU using the attached config file. > > Both CPU's maintain separate (overlapping) seqNums, see > ./src/cpu/o3/cpu.cc:1239 for further detail... > > > Thanks, > > Andrew Lukefahr > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
