----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1092/#review2313 -----------------------------------------------------------
These changes are reasonable, however, I made similar changes when trying to address this issue months ago. It would work for various switching frequencies but would fail for others. Please ensure that this works for the regressions for various switching frequencies. Also, make sure it works while switching back and forth between atomic <-> o3 at various switching frequencies. I know timing will not work with switching since it has its own issues with draining/switching out. - Anthony Gutierrez On March 14, 2012, 11:28 a.m., Andrew Lukefahr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1092/ > ----------------------------------------------------------- > > (Updated March 14, 2012, 11:28 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8896:ef11fde27ed4 > --------------------------- > updates > > > Diffs > ----- > > src/cpu/base.cc ad5f1f128fafebd4c6641f72c7872d669c1dc239 > src/cpu/o3/commit_impl.hh ad5f1f128fafebd4c6641f72c7872d669c1dc239 > src/cpu/o3/cpu.cc ad5f1f128fafebd4c6641f72c7872d669c1dc239 > src/cpu/o3/iew.hh ad5f1f128fafebd4c6641f72c7872d669c1dc239 > src/cpu/o3/lsq_unit.hh ad5f1f128fafebd4c6641f72c7872d669c1dc239 > > Diff: http://reviews.gem5.org/r/1092/diff/ > > > Testing > ------- > > Allows multiple switchouts of O3CPU using the attached config file. > > Both CPU's maintain separate (overlapping) seqNums, see > ./src/cpu/o3/cpu.cc:1239 for further detail... > > > Thanks, > > Andrew Lukefahr > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
