----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1109/#review2358 -----------------------------------------------------------
I'm curious how this issue arises in practice... wouldn't the scope of the templated range_map methods be disjoint from where this code would appear? I guess if it's a real issue with g++ 4.6 we need to fix it, but I'd like to understand better whether it's a true C++ error or just a g++ idiosyncrasy. - Steve Reinhardt On March 21, 2012, 4:40 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1109/ > ----------------------------------------------------------- > > (Updated March 21, 2012, 4:40 p.m.) > > > Review request for Default. > > > Description > ------- > > Power: Change bitfield name to avoid conflicts with range_map > > This patch changes the name of a bitfield from W to W_FIELD to avoid > clashes with W being used as a class (typename) in the templatized > range_map. The problem only manifested itself with gcc 4.6 after > seemingly unrelated changes, but is likely to cause similar issues in > the future and thus worth fixing. The relevant parts of the decoder > are updated. > > > Diffs > ----- > > src/arch/power/isa/bitfields.isa 4da2ea94319f > src/arch/power/isa/decoder.isa 4da2ea94319f > > Diff: http://reviews.gem5.org/r/1109/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
