----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1109/#review2366 -----------------------------------------------------------
Ship it! Thanks for digging in to the explanation... this makes sense. Surprised we didn't run into it sooner. - Steve Reinhardt On March 22, 2012, 2 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1109/ > ----------------------------------------------------------- > > (Updated March 22, 2012, 2 a.m.) > > > Review request for Default. > > > Description > ------- > > Power: Change bitfield name to avoid conflicts with range_map > > This patch changes the name of a bitfield from W to W_FIELD to avoid > clashes with W being used as a class (typename) in the templatized > range_map. It also changes L to L_FIELD to avoid future problems. The > problem manifestes itself when the CPU includes a header that in turn > includes range_map.hh. The relevant parts of the decoder are updated. > > > Diffs > ----- > > src/arch/power/isa/bitfields.isa 4da2ea94319f > src/arch/power/isa/decoder.isa 4da2ea94319f > > Diff: http://reviews.gem5.org/r/1109/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
