> On April 3, 2012, 3:29 p.m., Brad Beckmann wrote: > > Ship It! > > Andreas Hansson wrote: > I understand the urgency, and if we are indeed going with this fix for > now, then I'd suggest we create a list of dma ports rather than a list of dma > devices. That is, do not add the ide device to a list, but rather the ports > that are to be connected either to ruby or to the classic memory system. > > Nilay Vaish wrote: > This would necessitate making changes to all the files protocol config > files > present in configs/Ruby/. Andreas, is there any reason why you suggest > having > a list of ports?
If there are other masters (or master ports) on the IO bus then they would have to be connected as well, and there might be master ports that are not named "dma" but something different. Having an array of ports would be more general, and would simply connect what is in there either to Ruby or to the IO bus. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1102/#review2416 ----------------------------------------------------------- On March 24, 2012, 1:27 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1102/ > ----------------------------------------------------------- > > (Updated March 24, 2012, 1:27 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8918:e1988ccf8001 > --------------------------- > Ruby X86: problem in setting DMA port, related to the changeset 8850 > I think since the dma port is assigned twice (once in SouthBridge.py, > and once by Ruby somewhere) an extra port gets created which has no > peer port. This results in a segmentation fault when a simulation is > started. The posted patch solves the problem, but it is not the > solution I am looking for. Andreas, do you have some idea how to > handle this issue? > > > Diffs > ----- > > configs/common/FSConfig.py 7d95b650c9b6 > src/dev/x86/Pc.py 7d95b650c9b6 > src/dev/x86/SouthBridge.py 7d95b650c9b6 > > Diff: http://reviews.gem5.org/r/1102/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
