----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1102/#review2429 -----------------------------------------------------------
configs/example/ruby_mem_test.py <http://reviews.gem5.org/r/1102/#comment2840> Still needed? configs/example/ruby_mem_test.py <http://reviews.gem5.org/r/1102/#comment2841> dma_ports.append([dma.test for dma in dmas])? src/dev/x86/SouthBridge.py <http://reviews.gem5.org/r/1102/#comment2842> if self.ide.dma not in dma_ports? - Andreas Hansson On April 4, 2012, 11:46 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1102/ > ----------------------------------------------------------- > > (Updated April 4, 2012, 11:46 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8928:11ebb7f1d6de > --------------------------- > Ruby X86: problem in setting DMA port, related to the changeset 8850 > I think since the dma port is assigned twice (once in SouthBridge.py, > and once by Ruby somewhere) an extra port gets created which has no > peer port. This results in a segmentation fault when a simulation is > started. The posted patch solves the problem, but it is not the > solution I am looking for. Andreas, do you have some idea how to > handle this issue? > > > Diffs > ----- > > configs/common/FSConfig.py 570b44fe6e04 > configs/example/ruby_fs.py 570b44fe6e04 > configs/example/ruby_mem_test.py 570b44fe6e04 > configs/ruby/MESI_CMP_directory.py 570b44fe6e04 > configs/ruby/MI_example.py 570b44fe6e04 > configs/ruby/MOESI_CMP_directory.py 570b44fe6e04 > configs/ruby/MOESI_CMP_token.py 570b44fe6e04 > configs/ruby/MOESI_hammer.py 570b44fe6e04 > configs/ruby/Network_test.py 570b44fe6e04 > configs/ruby/Ruby.py 570b44fe6e04 > src/dev/x86/Pc.py 570b44fe6e04 > src/dev/x86/SouthBridge.py 570b44fe6e04 > > Diff: http://reviews.gem5.org/r/1102/diff/ > > > Testing > ------- > > Some rudimentary testing has been carried out to ensure that > ruby_fs, fs and mem_test are working. > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
