> On May 2, 2012, 8:24 a.m., Ali Saidi wrote: > > src/mem/packet.hh, line 136 > > <http://reviews.gem5.org/r/1169/diff/1/?file=26170#file26170line136> > > > > it's not used, but we probably need to bring this back. The current > > implementation isn't great either and needs some help. > >
Is this not covered by the more detailed attributes: IsSWPrefetch and IsHWPrefetch (line 139 and 140 in packet.hh)? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1169/#review2622 ----------------------------------------------------------- On May 2, 2012, 7:15 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1169/ > ----------------------------------------------------------- > > (Updated May 2, 2012, 7:15 a.m.) > > > Review request for Default. > > > Description > ------- > > Packet: Cleaning up packet command and attribute > > This patch removes unused commands and attributes from the packet to > avoid any confusion. It is part of an effort to clear up how and where > different commands and attributes are used. > > > Diffs > ----- > > src/mem/packet.hh 7f36d4436074 > src/mem/packet.cc 7f36d4436074 > > Diff: http://reviews.gem5.org/r/1169/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
