-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1200/#review2709
-----------------------------------------------------------
I think the implementation of WAIT is not correct. Here is what the man page
has to say
FUTEX_WAIT
This operation atomically verifies that the futex address uaddr
still
contains the value val, and sleeps awaiting FUTEX_WAKE on this
futex
address. If the timeout argument is non-NULL, its contents
describe
the maximum duration of the wait, which is infinite otherwise.
The
arguments uaddr2 and val3 are ignored.
In the current implementation, val is being not checked.
src/sim/syscall_emul.cc
<http://reviews.gem5.org/r/1200/#comment3064>
Unnecessary white space.
src/sim/syscall_emul.cc
<http://reviews.gem5.org/r/1200/#comment3063>
A single DPRINTF is good enough.
src/sim/syscall_emul.cc
<http://reviews.gem5.org/r/1200/#comment3065>
Do you know the Linux kernel / pthreads behavior in this case?
- Nilay Vaish
On May 16, 2012, 8:35 p.m., Marc Orr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/1200/
> -----------------------------------------------------------
>
> (Updated May 16, 2012, 8:35 p.m.)
>
>
> Review request for Default.
>
>
> Description
> -------
>
> Changeset 8984:c03d9113c68c
> ---------------------------
> syscall emulation: Add the futex system call.
>
>
> Diffs
> -----
>
> src/arch/x86/linux/syscalls.cc 4388495beb44ba859d20177371caf9e14902ef91
> src/sim/syscall_emul.hh 4388495beb44ba859d20177371caf9e14902ef91
> src/sim/syscall_emul.cc 4388495beb44ba859d20177371caf9e14902ef91
>
> Diff: http://reviews.gem5.org/r/1200/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marc Orr
>
>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
