> On May 20, 2012, 11:37 a.m., Ali Saidi wrote: > > src/arch/alpha/linux/linux.hh, line 146 > > <http://reviews.gem5.org/r/1200/diff/3/?file=26657#file26657line146> > > > > how about TGT_EAGAIN? > > > > Is EAGAIN the same for all OSes? should this be in kern/linux in that > > case? > > > >
Sure, I can rename to to TGT_EAGAIN. I don't know what TGT stand for or implies, so I guess that's why I wasn't using it. EAGAIN seems to be the same for all OSes except alpha: http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git&a=search&h=HEAD&st=grep&s=define.EAGAIN&sr=1 > On May 20, 2012, 11:37 a.m., Ali Saidi wrote: > > src/sim/syscall_emul.hh, line 355 > > <http://reviews.gem5.org/r/1200/diff/3/?file=26660#file26660line355> > > > > line length? > > Woops. - Marc ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1200/#review2744 ----------------------------------------------------------- On May 20, 2012, 11:12 a.m., Marc Orr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1200/ > ----------------------------------------------------------- > > (Updated May 20, 2012, 11:12 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8986:5bcb09faf751 > --------------------------- > syscall emulation: Add the futex system call. > > > Diffs > ----- > > src/arch/alpha/linux/linux.hh 4388495beb44ba859d20177371caf9e14902ef91 > src/arch/x86/linux/syscalls.cc 4388495beb44ba859d20177371caf9e14902ef91 > src/kern/linux/linux.hh 4388495beb44ba859d20177371caf9e14902ef91 > src/sim/syscall_emul.hh 4388495beb44ba859d20177371caf9e14902ef91 > src/sim/system.hh 4388495beb44ba859d20177371caf9e14902ef91 > > Diff: http://reviews.gem5.org/r/1200/diff/ > > > Testing > ------- > > Tested with m5threads test___threads executable and x86 ISA. > > > Thanks, > > Marc Orr > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
