----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1200/#review2744 -----------------------------------------------------------
src/arch/alpha/linux/linux.hh <http://reviews.gem5.org/r/1200/#comment3091> how about TGT_EAGAIN? Is EAGAIN the same for all OSes? should this be in kern/linux in that case? src/kern/linux/linux.hh <http://reviews.gem5.org/r/1200/#comment3093> here again TGT_ seems to be the way others are done src/kern/linux/linux.hh <http://reviews.gem5.org/r/1200/#comment3092> actually you did put it in kern/linux so why does it need to be in the alpha dir? src/sim/syscall_emul.hh <http://reviews.gem5.org/r/1200/#comment3094> line length? - Ali Saidi On May 20, 2012, 11:12 a.m., Marc Orr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1200/ > ----------------------------------------------------------- > > (Updated May 20, 2012, 11:12 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8986:5bcb09faf751 > --------------------------- > syscall emulation: Add the futex system call. > > > Diffs > ----- > > src/arch/alpha/linux/linux.hh 4388495beb44ba859d20177371caf9e14902ef91 > src/arch/x86/linux/syscalls.cc 4388495beb44ba859d20177371caf9e14902ef91 > src/kern/linux/linux.hh 4388495beb44ba859d20177371caf9e14902ef91 > src/sim/syscall_emul.hh 4388495beb44ba859d20177371caf9e14902ef91 > src/sim/system.hh 4388495beb44ba859d20177371caf9e14902ef91 > > Diff: http://reviews.gem5.org/r/1200/diff/ > > > Testing > ------- > > Tested with m5threads test___threads executable and x86 ISA. > > > Thanks, > > Marc Orr > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
