----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1287/#review3037 -----------------------------------------------------------
Ship it! A little off topic, but this makes me wonder... are we ever going to be able to merge ruby and classic memory controller models? It seems like that would be useful. - Steve Reinhardt On July 2, 2012, 10:43 p.m., Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1287/ > ----------------------------------------------------------- > > (Updated July 2, 2012, 10:43 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9075:3b3c9db76ebc > --------------------------- > ruby: memory controllers now inherit from an abstract "MemoryControl" class > > > Diffs > ----- > > src/mem/ruby/system/MemoryControl.hh > d8e5ca139d7c24eeb665ac0aab41e180886278cb > src/mem/ruby/system/MemoryControl.cc > d8e5ca139d7c24eeb665ac0aab41e180886278cb > src/mem/ruby/system/MemoryControl.py > d8e5ca139d7c24eeb665ac0aab41e180886278cb > src/mem/ruby/system/RubyMemoryControl.hh PRE-CREATION > src/mem/ruby/system/RubyMemoryControl.cc PRE-CREATION > src/mem/ruby/system/RubyMemoryControl.py PRE-CREATION > src/mem/ruby/system/SConscript d8e5ca139d7c24eeb665ac0aab41e180886278cb > src/mem/slicc/symbols/StateMachine.py > d8e5ca139d7c24eeb665ac0aab41e180886278cb > > Diff: http://reviews.gem5.org/r/1287/diff/ > > > Testing > ------- > > > Thanks, > > Brad Beckmann > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
