----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1287/#review3048 -----------------------------------------------------------
src/mem/ruby/system/MemoryControl.hh <http://reviews.gem5.org/r/1287/#comment3242> MemoryControlParams? src/mem/ruby/system/MemoryControl.hh <http://reviews.gem5.org/r/1287/#comment3241> Is init, drain, wakeup etc, not implicit from the SimObject? src/mem/ruby/system/MemoryControl.hh <http://reviews.gem5.org/r/1287/#comment3243> I thought this was a single channel controller? src/mem/ruby/system/RubyMemoryControl.cc <http://reviews.gem5.org/r/1287/#comment3247> Why not constructor initialisation list? src/mem/ruby/system/RubyMemoryControl.cc <http://reviews.gem5.org/r/1287/#comment3248> If it always has one, why a heap allocated object and not just a member? src/mem/ruby/system/RubyMemoryControl.cc <http://reviews.gem5.org/r/1287/#comment3249> whitespace src/mem/ruby/system/RubyMemoryControl.cc <http://reviews.gem5.org/r/1287/#comment3250> whitespace src/mem/ruby/system/RubyMemoryControl.cc <http://reviews.gem5.org/r/1287/#comment3251> whitespace src/mem/ruby/system/RubyMemoryControl.cc <http://reviews.gem5.org/r/1287/#comment3252> Could this possibly work? What if there are message in the queues? src/mem/ruby/system/RubyMemoryControl.py <http://reviews.gem5.org/r/1287/#comment3244> -2012? src/mem/ruby/system/RubyMemoryControl.py <http://reviews.gem5.org/r/1287/#comment3245> Why? src/mem/ruby/system/RubyMemoryControl.py <http://reviews.gem5.org/r/1287/#comment3246> Some comments would be great, but I understand this is just a rename/copy-paste. - Andreas Hansson On July 2, 2012, 10:43 p.m., Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1287/ > ----------------------------------------------------------- > > (Updated July 2, 2012, 10:43 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9075:3b3c9db76ebc > --------------------------- > ruby: memory controllers now inherit from an abstract "MemoryControl" class > > > Diffs > ----- > > src/mem/ruby/system/MemoryControl.hh > d8e5ca139d7c24eeb665ac0aab41e180886278cb > src/mem/ruby/system/MemoryControl.cc > d8e5ca139d7c24eeb665ac0aab41e180886278cb > src/mem/ruby/system/MemoryControl.py > d8e5ca139d7c24eeb665ac0aab41e180886278cb > src/mem/ruby/system/RubyMemoryControl.hh PRE-CREATION > src/mem/ruby/system/RubyMemoryControl.cc PRE-CREATION > src/mem/ruby/system/RubyMemoryControl.py PRE-CREATION > src/mem/ruby/system/SConscript d8e5ca139d7c24eeb665ac0aab41e180886278cb > src/mem/slicc/symbols/StateMachine.py > d8e5ca139d7c24eeb665ac0aab41e180886278cb > > Diff: http://reviews.gem5.org/r/1287/diff/ > > > Testing > ------- > > > Thanks, > > Brad Beckmann > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
