----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1293/#review3054 -----------------------------------------------------------
src/mem/ruby/system/CacheMemory.cc <http://reviews.gem5.org/r/1293/#comment3256> Just a bit surprised at the method of turning RubyRequestType_NUM into an int. Intentional? Why not (int) or static_cast<int>? src/mem/slicc/symbols/StateMachine.py <http://reviews.gem5.org/r/1293/#comment3257> Is this change intended to be part of this patch? - Andreas Hansson On July 5, 2012, 8:15 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1293/ > ----------------------------------------------------------- > > (Updated July 5, 2012, 8:15 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9088:dd6c331371c1 > --------------------------- > Ruby: convert cache memory stats to gem5's style > > > Diffs > ----- > > src/mem/ruby/profiler/CacheProfiler.hh ace8383f2b7e > src/mem/ruby/profiler/CacheProfiler.cc ace8383f2b7e > src/mem/ruby/profiler/SConscript ace8383f2b7e > src/mem/ruby/system/CacheMemory.hh ace8383f2b7e > src/mem/ruby/system/CacheMemory.cc ace8383f2b7e > src/mem/slicc/symbols/StateMachine.py ace8383f2b7e > > Diff: http://reviews.gem5.org/r/1293/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
