> On July 5, 2012, 10:02 a.m., Andreas Hansson wrote: > > src/mem/slicc/symbols/StateMachine.py, line 837 > > <http://reviews.gem5.org/r/1293/diff/1/?file=27689#file27689line837> > > > > Is this change intended to be part of this patch?
This is correct. The code in question is being used to call the printStats() method. Earlier both CacheMemory and DirectoryMemory appeared in the check. But since statistics related to CacheMemory are being moved, so there is no need to call the printStats() method on CacheMemory. But DirectoryMemory will still use Ruby's style. It will also be converted in due course. > On July 5, 2012, 10:02 a.m., Andreas Hansson wrote: > > src/mem/ruby/system/CacheMemory.cc, line 515 > > <http://reviews.gem5.org/r/1293/diff/1/?file=27688#file27688line515> > > > > Just a bit surprised at the method of turning RubyRequestType_NUM into > > an int. Intentional? Why not (int) or static_cast<int>? I just copied the code that was present in CacheProfiler.cc file earlier. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1293/#review3054 ----------------------------------------------------------- On July 5, 2012, 8:15 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1293/ > ----------------------------------------------------------- > > (Updated July 5, 2012, 8:15 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9088:dd6c331371c1 > --------------------------- > Ruby: convert cache memory stats to gem5's style > > > Diffs > ----- > > src/mem/ruby/profiler/CacheProfiler.hh ace8383f2b7e > src/mem/ruby/profiler/CacheProfiler.cc ace8383f2b7e > src/mem/ruby/profiler/SConscript ace8383f2b7e > src/mem/ruby/system/CacheMemory.hh ace8383f2b7e > src/mem/ruby/system/CacheMemory.cc ace8383f2b7e > src/mem/slicc/symbols/StateMachine.py ace8383f2b7e > > Diff: http://reviews.gem5.org/r/1293/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
