----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1293/#review3076 -----------------------------------------------------------
Nilay, can you hold off checking this patch in until I commit my changes. We have a lot of internal code that uses the current Cache Profiler that I'll need to change. I'd rather not do that in the next few weeks. This patch reminds me of a larger question that is worth revisiting. Is now the time to convert Ruby stats to gem5 stats, since gem5 stats are now python objects and can potentially be outputted in any format. The last half of that statement may be a streach, so please correct me if that's untrue. As you know, I've been relucant to convert Ruby stats to gem5 stats because many Ruby stats are useful in the debugging process, and Ruby's more condense format is much more readable. Meanwhile, the default gem5 stats format is optimized for data extraction. If we could use the new python support to generate an output file that looks a lot like the current ruby.stats file, then now maybe a good time to switch. This is probably a better topic for a separate thread, but I wanted to mention that thought before I forgot. - Brad Beckmann On July 5, 2012, 8:15 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1293/ > ----------------------------------------------------------- > > (Updated July 5, 2012, 8:15 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9088:dd6c331371c1 > --------------------------- > Ruby: convert cache memory stats to gem5's style > > > Diffs > ----- > > src/mem/ruby/profiler/CacheProfiler.hh ace8383f2b7e > src/mem/ruby/profiler/CacheProfiler.cc ace8383f2b7e > src/mem/ruby/profiler/SConscript ace8383f2b7e > src/mem/ruby/system/CacheMemory.hh ace8383f2b7e > src/mem/ruby/system/CacheMemory.cc ace8383f2b7e > src/mem/slicc/symbols/StateMachine.py ace8383f2b7e > > Diff: http://reviews.gem5.org/r/1293/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
