----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1618/#review3817 -----------------------------------------------------------
I believe the HandyM5Reg value is already serialized as part of the misc reg file. I think you could solve the problem with fewer changes just by calling decoder->setM5Reg after unserializing the register file. I assume the reason Gabe didn't use an m5reg like you are doing here is because that's a big bit field, so you're paying the cost of extracting and inserting things into the bit field on every decode, instead of only paying that cost when the values change. - Steve Reinhardt On Jan. 11, 2013, 12:16 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1618/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2013, 12:16 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9463:5404b8587e1b > --------------------------- > x86: Changes to decoder, partly rolls back 9376 > The changes made by the changeset 9376 were not quite correct. The patch > created > changes to the code which resulted in decoder not getting initialized > correctly > when the state was restored from a checkpoint. > > Since a lot many changes have taken place since, it was not so straight > forward > to do away with the error. The decoder's state is being added to the > checkpoint > so that the decoder can read the state correctly. Changes have been made to > the > util/cpt_upgrader.py script to fix existing checkpoints. I do not expect any > architecture other than x86 to have the bug stated above. > > > Diffs > ----- > > src/arch/x86/decoder.hh 5532a1642108 > src/arch/x86/decoder.cc 5532a1642108 > src/cpu/simple_thread.cc 5532a1642108 > src/sim/serialize.hh 5532a1642108 > util/cpt_upgrader.py 5532a1642108 > > Diff: http://reviews.gem5.org/r/1618/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
