On Fri, 11 Jan 2013, Steve Reinhardt wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1618/#review3817
-----------------------------------------------------------
I believe the HandyM5Reg value is already serialized as part of the misc
reg file. I think you could solve the problem with fewer changes just
by calling decoder->setM5Reg after unserializing the register file.
The misc reg file is part of the isa section of the checkpoint and the isa
is now a separate sim object. The decoder can only be accessed via the
simple thread structure. This means that the isa should be unserialized
before the thread state. I think we do want to rely on the ordering. And
there is no initialization function that is called after loadState() has
been called on the sim objects.
I assume the reason Gabe didn't use an m5reg like you are doing here is
because that's a big bit field, so you're paying the cost of extracting
and inserting things into the bit field on every decode, instead of only
paying that cost when the values change.
Actually I had thought of a different solution initially, which led me to
remove all those fields. I'll restore them.
--
Nilay
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
