----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1829/#review4263 -----------------------------------------------------------
It's not a part of the codebase that I'm very familiar with, so excuse me if I'm being unfair here, but I would argue it needs a bit more comments. It is not an "intuitive" solution and it would be good to have some of the thought process baked into the code. For the rest, if it solves the problem... :-) - Andreas Hansson On April 19, 2013, 3:25 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1829/ > ----------------------------------------------------------- > > (Updated April 19, 2013, 3:25 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9643:0c08519fc657 > --------------------------- > ruby: patch checkpoint restore with garnet > Due to recent changes to clocking system in Ruby and the way Ruby restores > state from a checkpoint, garnet was failing to run from a checkpointed > state. This patch makes changes so that garnet can successfully run from > checkpointed state. > > It adds a global visible time at which the actual execution started. > This time is initialized in RubySystem::startup() function. This variable > is only meant for components with in Ruby. This replaces the private > variable that was maintained within Garnet since it is not possible > to figure out the best when the value of this variable can be set. > > The patch also does away with all cases where curCycle() is called with in > some Ruby component before the system has actually started executing. This > is required due to the quirky manner in which ruby restores from a checkpoint. > > > Diffs > ----- > > src/mem/ruby/common/Global.hh 112382ddf96d > src/mem/ruby/common/Global.cc 112382ddf96d > src/mem/ruby/network/garnet/BaseGarnetNetwork.hh 112382ddf96d > src/mem/ruby/network/garnet/BaseGarnetNetwork.cc 112382ddf96d > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 112382ddf96d > src/mem/ruby/network/garnet/fixed-pipeline/InputUnit_d.cc 112382ddf96d > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc > 112382ddf96d > src/mem/ruby/network/garnet/fixed-pipeline/OutVcState_d.hh 112382ddf96d > src/mem/ruby/network/garnet/fixed-pipeline/OutVcState_d.cc 112382ddf96d > src/mem/ruby/network/garnet/fixed-pipeline/VirtualChannel_d.hh 112382ddf96d > src/mem/ruby/network/garnet/fixed-pipeline/VirtualChannel_d.cc 112382ddf96d > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc 112382ddf96d > src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc > 112382ddf96d > src/mem/ruby/network/garnet/flexible-pipeline/OutVcState.cc 112382ddf96d > src/mem/ruby/network/orion/NetworkPower.cc 112382ddf96d > src/mem/ruby/profiler/Profiler.cc 112382ddf96d > src/mem/ruby/system/System.hh 112382ddf96d > src/mem/ruby/system/System.cc 112382ddf96d > > Diff: http://reviews.gem5.org/r/1829/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
