Hi Nilay, Sorry to be a pain, but the drawback with putting this information in the patch description is that the observability is close to 0 once it is committed.
A comment in the source is right there and readily available. If nothing else, is there a suitable spot in a header or similar to copy-paste the description to? Thanks, Andreas On 20/04/2013 19:24, "Nilay Vaish" <[email protected]> wrote: >On Sat, 20 Apr 2013, Andreas Hansson wrote: > >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviews.gem5.org/r/1829/#review4263 >> ----------------------------------------------------------- >> >> >> It's not a part of the codebase that I'm very familiar with, so excuse >> me if I'm being unfair here, but I would argue it needs a bit more >> comments. It is not an "intuitive" solution and it would be good to >>have >> some of the thought process baked into the code. >> >> For the rest, if it solves the problem... :-) >> >> - Andreas Hansson >> >> > > >I have updated the patch's description. I think it is enough. > >-- >Nilay > -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
