On Sat, 20 Apr 2013, Andreas Hansson wrote:


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1829/#review4263
-----------------------------------------------------------


It's not a part of the codebase that I'm very familiar with, so excuse me if I'm being unfair here, but I would argue it needs a bit more comments. It is not an "intuitive" solution and it would be good to have some of the thought process baked into the code.

For the rest, if it solves the problem... :-)

- Andreas Hansson




I have updated the patch's description. I think it is enough.

--
Nilay
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to