----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2248/#review5085 -----------------------------------------------------------
Are all these changes really related to the ISA split? Some look like independent bug fixes/enhancements. Those should be separate changesets, and that parts that are truly interdependent with the ISA split code (if there are any) should be integrated with the other ISA split patch. src/SConscript <http://reviews.gem5.org/r/2248/#comment4616> is this change related to the dynamic/multiple ISA file change? it looks like an independent bug fix tests/SConscript <http://reviews.gem5.org/r/2248/#comment4617> are the changes in this file related to the ISA changes? they don't appear to be - Steve Reinhardt On April 23, 2014, 5:23 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2248/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 5:23 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10200:0e0cf51add93 > --------------------------- > arch: support dynamic ISA file generation in SConscripts > > > Diffs > ----- > > SConstruct e40b35147270 > src/SConscript e40b35147270 > src/arch/SConscript e40b35147270 > tests/SConscript e40b35147270 > > Diff: http://reviews.gem5.org/r/2248/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
