-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2248/#review5088
-----------------------------------------------------------



src/SConscript
<http://reviews.gem5.org/r/2248/#comment4618>

    I suppose this change could be applied independent of the ISA splitting 
work, but it wouldn't "fix" anything in that case.  (It'd be pointless/change 
for change's sake)
    
    With dynamic source files as a result of ISA splitting, makeEnv() gets 
called during the build instead of before it.  This makes dealing with 
pathnames more challenging since chdir()'s are happening asynchronously in 
parallel with what makeEnv() might be doing.  This little bit of code helps to 
work around that issue.



tests/SConscript
<http://reviews.gem5.org/r/2248/#comment4619>

    Like the other bit of code you commented on, this makes the code deal with 
absolute paths rather than relative paths.  It's not necessary in isolation.


It was my intention for all of this to be all "required" for ISA splitting; 
these changes just address one aspect of the solution.  If one single changeset 
is desired, this should be folded into the other ISA splitting changes.

- Curtis Dunham


On April 23, 2014, 12:23 p.m., Andreas Hansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2248/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 12:23 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 10200:0e0cf51add93
> ---------------------------
> arch: support dynamic ISA file generation in SConscripts
> 
> 
> Diffs
> -----
> 
>   SConstruct e40b35147270 
>   src/SConscript e40b35147270 
>   src/arch/SConscript e40b35147270 
>   tests/SConscript e40b35147270 
> 
> Diff: http://reviews.gem5.org/r/2248/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Hansson
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to