On May 5, 2014, 8:44 a.m., Andreas Hansson wrote: > > It was my intention for all of this to be all "required" for ISA splitting; > > these changes just address one aspect of the solution. If one single > > changeset is desired, this should be folded into the other ISA splitting > > changes.
I don't really desire a single changeset. The most important thing (to me, anyway) is that changesets transform the code from one working state to another working state. So if there are changes to the SConstruct/SConscripts that are *necessary* for the changes in the ISA parser to work, then they should be in the same changeset, so that applying one patch but not the other doesn't break things. Given that, it's desirable (though less imperative) to break things down into small self-consistent units. There's no requirement that a patch "stand alone" in terms of completely providing a tangible feature or fixing a bug; it only needs to "stand alone" in terms of not breaking things. It's also very valuable to describe the purpose and motivation of changes. For example, your description of why it's valuable to switch from relative to absolute paths was very enlightening, but wasn't anywhere in the patch or the commit message, where it would be very useful to have for posterity. In general, we tend to put too much in the commit message and not enough in comments, but in this case (since the history will be irrelevant to people who are reading the code) I think the commit message is where that should go. So in this case, I think it would be very appropriate to have a patch that's something like "Switch SConscripts from relative to absolute pathnames", then in the commit message you could explain why it's functionally neutral by itself, but is important preparation for the upcoming ISA splitting changes. This is really the same concept as committing all the code to enable splitting ISA outputs in one patch, and then committing the changes to the ARM ISA description in a second patch (which is the right thing to do)---note that the first patch by itself doesn't really "do anything" either, but since it doesn't break anything, separating the ARM changes gives us smaller but still self-consistent changes. Obviously this is all somewhat subjective; if anyone else wants to add anything to the discussion please speak up. Perhaps if we come up with agreed-upon guidelines it should go on the wiki. There's a little bit of a discussion in one of the bullets at http://gem5.org/Commit_Access but it could be expanded. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2248/#review5088 ----------------------------------------------------------- On April 23, 2014, 5:23 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2248/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 5:23 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10200:0e0cf51add93 > --------------------------- > arch: support dynamic ISA file generation in SConscripts > > > Diffs > ----- > > SConstruct e40b35147270 > src/SConscript e40b35147270 > src/arch/SConscript e40b35147270 > tests/SConscript e40b35147270 > > Diff: http://reviews.gem5.org/r/2248/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
