----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2276/#review5104 -----------------------------------------------------------
src/mem/ruby/system/Sequencer.cc <http://reviews.gem5.org/r/2276/#comment4622> Not sure what your thoughts are, but using "auto" would clean it up quite a bit (here and other places in the file). - Andreas Hansson On May 14, 2014, 5:47 a.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2276/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 5:47 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10228:f377969aa1b2 > --------------------------- > ruby: don't make O3 CPU squash on loads that hit outstanding requests > > Mismatch between O3 and Ruby in handling aliased requests: Ruby > returns false when it sees aliased request or memory blocked. O3 > squash and refetch when it sees false signal from Ruby. > > Fix: Merging readRequestTable and writeRequestTable in a single table > that maps requesting address and all requests that are aliased with > the address. > > This work was done while Binh was an intern at AMD Research. > > > Diffs > ----- > > src/mem/ruby/system/Sequencer.hh 34f48d0dac97d04f3d1e129a1f4aa00d869b1d8f > src/mem/ruby/system/Sequencer.cc 34f48d0dac97d04f3d1e129a1f4aa00d869b1d8f > > Diff: http://reviews.gem5.org/r/2276/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
