----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2315/#review5197 -----------------------------------------------------------
Ship it! Thanks for fixing this! The changeset looks good, but I'd appreciate if you could shorten the summary line (the first line) of the commit message to comply with the commit requirements (http://www.gem5.org/Commit_Access). The maximum line length for the summary line is 65 characters. Something like this should suffice as a summary line: "config, x86: Ensure that PCI devs get bridged to the memory bus" Other than the above, I'm happy to have this committed. - Andreas Sandberg On July 17, 2014, 6:29 a.m., Jiuyue Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2315/ > ----------------------------------------------------------- > > (Updated July 17, 2014, 6:29 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > config: force IO devices mapped to 0xC0000000-0xFFFF0000 and bridge these > address to iobus for x86 > > This patch force IO device to be mapped to 0xC0000000-0xFFFF0000 by > reserve anything between the end of memory and 3GB if memory is less > than 3GB. It also statically bridge these address range to the IO bus, > which guaranty access to pci address space will pass though bridge to > iobus. > > > Diffs > ----- > > configs/common/FSConfig.py 878f2f30b12d38f619b80b5d80d52498946f6ad1 > > Diff: http://reviews.gem5.org/r/2315/diff/ > > > Testing > ------- > > > Thanks, > > Jiuyue Ma > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
