> On March 12, 2014, 7:46 p.m., Andreas Hansson wrote: > > src/mem/ruby/system/DMASequencer.hh, line 92 > > <http://reviews.gem5.org/r/2208/diff/1/?file=39423#file39423line92> > > > > Coming back to a previous discussion, is this really needed? Should > > not the src/dst be enough?
This structure is not being used. I am dropping the code. > On March 12, 2014, 7:46 p.m., Andreas Hansson wrote: > > src/mem/ruby/system/DMASequencer.cc, line 46 > > <http://reviews.gem5.org/r/2208/diff/1/?file=39424#file39424line46> > > > > why dynamically allocated? No need for dynamic allocation. Changing to static. > On March 12, 2014, 7:46 p.m., Andreas Hansson wrote: > > src/mem/ruby/system/DMASequencer.cc, line 110 > > <http://reviews.gem5.org/r/2208/diff/1/?file=39424#file39424line110> > > > > Is this really needed? I am retaining this code for the time being. At some point in future, I will revisit all the places in ruby where the behaviour is dependent on whether tester is in use or not. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2208/#review4979 ----------------------------------------------------------- On Sept. 25, 2014, 4:39 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2208/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 4:39 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10416:bc430ee79714 > --------------------------- > ruby: dma sequencer: remove RubyPort as parent class > As of now DMASequencer inherits from the RubyPort class. But the code in > RubyPort class is heavily tailored for the CPU Sequencer. There are parts of > the code that are not required at all for the DMA sequencer. Moreover, the > next patch uses the dma sequencer for carrying out memory accesses for all the > io devices. Hence, it is better to have a leaner dma sequencer. > > > Diffs > ----- > > src/mem/ruby/system/DMASequencer.hh d96740732a61 > src/mem/ruby/system/DMASequencer.cc d96740732a61 > src/mem/ruby/system/Sequencer.py d96740732a61 > > Diff: http://reviews.gem5.org/r/2208/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
