----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2466/#review5423 -----------------------------------------------------------
Thanks Nilay. I have couple comments below. src/mem/ruby/system/RubyPort.cc <http://reviews.gem5.org/r/2466/#comment4903> This comment should be updated. src/mem/ruby/system/System.hh <http://reviews.gem5.org/r/2466/#comment4904> Making this a static variable seems dangerous. With this change, one could not use a ruby protocol that needs a backing store (second copy of phys mem) in multi-system simulation. Can you make it non-static instead? - Brad Beckmann On Oct. 21, 2014, 10:01 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2466/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 10:01 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10497:587c77ab8adc > --------------------------- > ruby: provide a second copy of the memory > This memory is required in some cases. It can be enabled by invoking > the option --access-phys-mem > > > Diffs > ----- > > configs/ruby/Ruby.py ffe6ab7141ab > src/mem/ruby/system/DMASequencer.hh ffe6ab7141ab > src/mem/ruby/system/DMASequencer.cc ffe6ab7141ab > src/mem/ruby/system/RubyPort.hh ffe6ab7141ab > src/mem/ruby/system/RubyPort.cc ffe6ab7141ab > src/mem/ruby/system/RubySystem.py ffe6ab7141ab > src/mem/ruby/system/Sequencer.py ffe6ab7141ab > src/mem/ruby/system/System.hh ffe6ab7141ab > src/mem/ruby/system/System.cc ffe6ab7141ab > > Diff: http://reviews.gem5.org/r/2466/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
